[Buildroot] [PATCH 1/7] package/gstreamer1/gstreamer1: add optional support for libcap
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun Feb 21 17:23:36 UTC 2016
Bernd,
On Sun, 21 Feb 2016 15:48:39 +0100, Bernd Kuhls wrote:
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +GSTREAMER1_CONF_OPTS += --with-ptp-helper-permissions=capabilities
> +GSTREAMER1_DEPENDENCIES += libcap
> +else
> +GSTREAMER1_CONF_OPTS += --with-ptp-helper-permissions=auto
> +endif
I am not entirely sure about this one. When BR2_PACKAGE_LIBCAP=y, are
we sure that the user wants to use capabilities for everything
including this GStreamer feature? There are other possible values for
--with-ptp-helper-permissions. So it would be good to have a commit log
that details a bit more the reasoning, other than just "it might use
libcap, so let's use it".
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list