[Buildroot] [PATCH v3 1/2] package/libsoil: fix build using old versions of patch

Peter Korsgaard peter at korsgaard.com
Sat Feb 20 22:26:42 UTC 2016


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Dear Ricardo Martincoski,
 > On Sun, 24 Jan 2016 11:19:52 -0200, Ricardo Martincoski wrote:
 >> Well-formed patch fails to apply
 >> - patch v2.6:
 >> Hunk #1 FAILED at 1.
 >> Hunk #2 FAILED at 23.
 >> - patch v2.6.1:
 >> can't find file to patch at input line 11
 >> Perhaps you used the wrong -p or --strip option?
 >> [snip]
 >> No file to patch.  Skipping patch.
 >> 2 out of 2 hunks ignored
 >> Patch failed!  Please fix 0001-fix-makefile.patch!
 >> 
 >> Old versions of the tool "patch" cannot handle spaces in filenames.
 >> The same does not occur using "patch" v2.7 or any later.
 >> 
 >> Workaround: when a file with space in the name needs to be patched,
 >> one or two hooks must be used.
 >> A pre-patch or post-extract hook renames the file to replace spaces
 >> with underscores.
 >> The patch file must be generated using diff between two source-trees
 >> that have the file renamed with spaces replaced by underscores.
 >> A post-patch hook could rename the file to its original name if needed.
 >> 
 >> Fixes:
 >> http://autobuild.buildroot.net/results/8ff/8ff91ab8e52000eb34dd8f662520cf1b31490cf5/
 >> http://autobuild.buildroot.net/results/ea7/ea77d6b23aca0cb1cf527e6c16ddf5eba957a69c/
 >> 
 >> Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
 >> Cc: Bernd Kuhls <bernd.kuhls at t-online.de>
 >> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
 >> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 > Applied, thanks.

I think we should add a comment in the .mk to explain why we're doing
this odd rename. I'll do so now.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list