[Buildroot] [PATCH v8 1/1] package/dhcp: bump version to 4.3.3-P1

[rdkehn at yahoo.com]

Hi Arnout, Ricardo,

On Tue, Feb 16, 2016 at 09:51:35PM +0100, Arnout Vandecappelle wrote:
> On 15-02-16 00:19, Ricardo Martincoski wrote:
> > Doug, Arnout,
> > 
> > On Sun, Feb 14, 2016 at 02:24 PM, Doug Kehn <rdkehn at yahoo.com> wrote:
> >> +# bind configure is called via dhcp make instead of dhcp configure. The make env
> >> +# needs extra values for bind configure.
> >> +DHCP_MAKE_ENV = \
> >> +	$(TARGET_CONFIGURE_OPTS) \
> >> +	BUILD_CC="$(HOSTCC)" \
> >> +	BUILD_CFLAGS="$(HOST_CFLAGS)" \
> >> +	BUILD_CPPFLAGS="$(HOST_CXXFLAGS)" \
> > 
> > It is conceptually wrong. Probably a typo.
> > 
> > https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html
> > CXXFLAGS  Extra flags to give to the C++ compiler.
> > CPPFLAGS  Extra flags to give to the C preprocessor and programs that
> >           use it (the C and Fortran compilers).
> > 

Yeah, that is a typo.


> >> +	BUILD_LDFLAGS="$(HOST_LDFLAGS)"
> >> +
> > 
> > 
> > Arnout,
> > Can you confirm this is what you suggested?
> > 
> > DHCP_MAKE_ENV = \
> > 	$(TARGET_CONFIGURE_OPTS) \
> > 	BUILD_CC="$(HOSTCC)" \
> > 	BUILD_CFLAGS="$(HOST_CFLAGS)" \
> > 	BUILD_CPPFLAGS="$(HOST_CPPFLAGS)" \
> > 	BUILD_LDFLAGS="$(HOST_LDFLAGS)"
> 
>  Indeed it was. I shouldn't have told Doug to add my Reviewed-by it seems :-)

It didn't feel right adding a Reviewed-by. I'll make one more
attempt.

Regards,
...doug