[Buildroot] [PATCH v3] valgrind: fix musl compile
Peter Seiderer
ps.report at gmx.net
Thu Feb 11 20:18:45 UTC 2016
Hello Arnout,
On Wed, 10 Feb 2016 00:26:34 +0100, Arnout Vandecappelle <arnout at mind.be> wrote:
> On 09-02-16 23:53, Peter Seiderer wrote:
> > Add musl libc detection (based on suggestions by Romain Naour and
> > Arnout Vandecappelle) and add some tweaks for musl support (based
> > on OpenWRT patch [1]).
> >
> > Fixes ([2]):
> > checking the glibc version... unsupported version
> > configure: error: Valgrind requires glibc version 2.2 or later
> >
> > Patch suggested upstream (see [3]).
> >
> > [1] https://dev.openwrt.org/browser/trunk/package/devel/valgrind/patches/200-musl_fix.patch?rev=46302
> > [2] http://autobuild.buildroot.org/results/7b0/7b048ba58918f0a08498c61327fcf35a85a84837
> > [3] https://bugs.kde.org/show_bug.cgi?id=359202
> >
> > Signed-off-by: Peter Seiderer <ps.report at gmx.net>
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>
> One small nit:
>
> [snip]
> > + AC_MSG_RESULT([unsupported version ${GLIBC_VERSION}])
> > +- AC_MSG_ERROR([Valgrind requires glibc version 2.2 or later,])
> > +- AC_MSG_ERROR([Darwin libc, Bionic libc or Solaris libc])
> > ++ AC_MSG_ERROR([Valgrind requires glibc version 2.2 or later, uclibc,])
>
> It's uClibc (capital C).
O.k, fixed it (and many thanks for review patience)...
>
> > ++ AC_MSG_ERROR([musl libc, Darwin libc, Bionic libc or Solaris libc])
> > + ;;
> > + esac
> > +
> [snip]
>
> I guess you'll update the upstream bug report as well?
>
Yes, done now...
Regards,
Peter
> Regards,
> Arnout
>
>
More information about the buildroot
mailing list