[Buildroot] [PATCH v9] board: add support for ARM Juno r0 and r1 Development Boards
Joao Pinto
Joao.Pinto at synopsys.com
Thu Feb 4 11:15:27 UTC 2016
Hi Thomas,
I will check it and send a v10 today. Thanks for the buildroot' defconfig tip.
Joao
On 2/3/2016 11:07 PM, Thomas Petazzoni wrote:
> Joao,
>
> On Wed, 3 Feb 2016 18:20:30 +0000, Joao Pinto wrote:
>> The Juno ARM Development Platform (ADP) is a software development
>> platform for ARMv8-A, it includes the Juno Versatile Express board
>> and an ARMv8-A reference software port available through Linaro.
>>
>> Signed-off-by: Joao Pinto <jpinto at synopsys.com>
>
> I am not sure why your v9 does not appear in patchwork, but v8 does.
> Anyway, this is still not good, because the kernel commit your
> defconfig uses no longer exists in the Linaro Git repository, so the
> download fails:
>
>>>> linux 0d752ce2de3057e12e220d104beb02744147be4f Downloading
> Doing full clone
> Cloning into bare repository 'linux-0d752ce2de3057e12e220d104beb02744147be4f'...
> fatal: not a tree object
>
> It works for you because you have the tarball'ed kernel in your
> $(BR2_DL_DIR), but it won't work for anyone else.
>
> You should make sure to use a commit in a branch that the Linaro
> developers will not rebase, otherwise the commit will disappear in the
> future.
>
> Also, another problem of your submission is that you're adding two
> defconfigs, while there's no reason to do so. The only difference
> between the two is the Device Tree to be built. And we can perfectly
> build two Device Trees in a single defconfig.
>
> So could you apply the attached patch on top of yours (which addresses
> this problem), and squash it with your commit ?
>
> Thanks!
>
> Thomas
>
More information about the buildroot
mailing list