[Buildroot] [PATCH 1/1] luarocks: fix target-finalize hook processing
Peter Korsgaard
peter at korsgaard.com
Wed Dec 28 22:58:03 UTC 2016
>>>>> "Danomi" == Danomi Manchego <danomimanchego123 at gmail.com> writes:
> The LUAROCKS_TARGET_FINALIZE_HOOKS is not running, so detritus
> it being left in /usr/lib/luarocks. This is because luarocks is
host-luarocks actually.
> built by being a dependency in the luarocks package infrastructure,
> not by being selected by kconfig symbol. This means that the
> $(PKG)_KCONFIG_VAR in pkg-generic.mk is not met, and
> (HOST_)LUAROCKS_TARGET_FINALIZE_HOOKS is not added to the global
> TARGET_FINALIZE_HOOKS.
> This mod fixes this issue by adding the host-luarocks hook directly
> to TARGET_FINALIZE_HOOKS when either lua or luajit is enabled.
> Signed-off-by: Danomi Manchego <danomimanchego123 at gmail.com>
> ---
> package/luarocks/luarocks.mk | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> diff --git a/package/luarocks/luarocks.mk b/package/luarocks/luarocks.mk
> index 4e0d537..d18056a 100644
> --- a/package/luarocks/luarocks.mk
> +++ b/package/luarocks/luarocks.mk
> @@ -60,4 +60,7 @@ define LUAROCKS_FINALIZE_TARGET
> rm -rf $(TARGET_DIR)/usr/lib/luarocks
> endef
> -LUAROCKS_TARGET_FINALIZE_HOOKS += LUAROCKS_FINALIZE_TARGET
Even if the Config.in option was set, this wouldn't have worked as we
are using host-luarocks, not luarocks.
Committed, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list