[Buildroot] [PATCH] usbip: add a new package

Tal Shorer tal.shorer at gmail.com
Mon Dec 12 22:17:54 UTC 2016


On Mon, Dec 12, 2016 at 7:25 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Tal, Arnout, All,
>
> On 2016-12-12 10:40 +0100, Arnout Vandecappelle spake thusly:
>> On 11-12-16 23:30, Tal Shorer wrote:
>> > Both don't deal with source-check, though. I think we should consider
>> > linux-tools again at this point, since it doesn't have any of these
>> > problems (it has its own problems, but I'm beginning to think I'd
>> > rather deal with those). If nobody objects to this approach I'll
>>
>>  +1 to that approach.
>
> Still, I don't like the custom autotools commands we'll have to have.
> What about (mock-up, just for the sake of the example):
>
>     ###############
>     # usbip
>     ###############
>
>     # No USBIP_SITE, no USB_VERSION, we vampirise the code from the
>     # linux kernel
>     USBIP_PATCH_DEPENDENCIES = linux
>
>     USBIP_SRC_DIR = $)(wildcard \
>         $(LINUX_DIR)/tools/usb/usbip \
>         $(LINUX_DIR)/drivers/staging/blabla)
>
>     define USBIP_EXTRACT_CMDS
>         if [ -z "$(USB_SRC_DIR)" ]; then \
>             echo "No usbip source in your kernel tree" 2>&1; \
>             exit 1; \
>         fi
>         rsync $(USB_SRC_DIR) $(@D)
>     endef
>
>     $(eval $(autotools-package))
>
> This way, we still have a proper autotools package, we don;t fail on
> source-check, and we re-use the kernel sources.
This works after some modifications. We end up duplicating the rsync
command from pkg-generic, but the argument that this is better than
duplicating the configure command is easily made.
I'll send a new patch
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list