[Buildroot] [PATCH RFC] Revert "Added local directory as source of kernel code"
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun Aug 28 07:23:39 UTC 2016
Hello,
On Sun, 28 Aug 2016 00:54:29 +0200, Yann E. MORIN wrote:
> > > # Compute LINUX_SOURCE and LINUX_SITE from the configuration
> > > -ifeq ($(BR2_LINUX_KERNEL_CUSTOM_TARBALL),y)
> > > +ifeq ($(LINUX_VERSION),custom)
> >
> > Why are you doing this change?
>
> Before, both local tarball and local directory could set LINUX_VERSION
> to "custom". Now only the local tarball can. So I switched.
>
> In restrospect, this change is not nice: all other cases deal with the
> option from the choice, so we should indeed keep it for local tarball
> too. Besides, LINUX_VERSION is derived from the local tarball option, so
> better to use the "mother" option than the derived one.
Exactly my thinking.
> I'll fix that and take care of legacy, then respin.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list