[Buildroot] [PATCH 05/16 v3] core: move rule to create basic directories

Yann E. MORIN yann.morin.1998 at free.fr
Sat Aug 27 22:07:05 UTC 2016


Thomas, All,

On 2016-08-27 21:41 +0200, Thomas Petazzoni spake thusly:
> On Sun, 17 Jul 2016 12:34:25 +0200, Yann E. MORIN wrote:
> > Some of those directories will be needed even during configuration, like
> > BUILD_DIR, where we'll store the generated kconfig snippet.
> > 
> > So, move the rule to create them outside the HAVE_CONFIG block.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> > Cc: Peter Korsgaard <jacmet at uclibc.org>
> 
> I've applied this patch to next, after fixing the typo in the commit
> log noticed by Romain Naour. One question below, though.

Thanks! :-)

> > +################################################################################
> > +#
> > +# staging and target directories do NOT list these as
> > +# dependencies anywhere else
> > +#
> > +################################################################################
> 
> Do you understand what this comment means? It seems to date back from
> the "major rework" commit 08782ae7d8812933ad3f932132955ea1c0fb1e52 in
> 2002, and I don't really understand the meaning of this comment.

Neither do I... And as a once-colleague-of-mine said:

    When you don't know, don't touch!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list