[Buildroot] [PATCH 4/4 v3] kodi: allow enablement of libamcodec as codec if selected
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sat Aug 27 20:30:13 UTC 2016
Hello,
On Sat, 2 Jul 2016 19:58:21 +0200, daggs wrote:
> as prefix is set to /usr (see output/build/kodi-16.1-Jarvis/config.log), I'm not sure fixing prefix is the answer.
> in general, replacing the include lines with the follows:
> INCLUDES += -I$(shell $(CC) --print-sysroot)/$(prefix)/include/amcodec
> INCLUDES += -I$(shell $(CC) --print-sysroot)/$(prefix)/include/amplayer
You can also do:
-I=$(prefix)/include/amcodec
'=' is automatically replaced by gcc by the sysroot path. However, as
it was discussed, there should be a choice between:
- amcodec headers are meant to be installed in /usr/include/amcodec,
in which case Kodi should #include <amcodec/foobar.h>, and then the
amcodec headers also use #include <amcodec/barfoo.h> internally.
- amcodec headers are meant to be installed in /usr/include/
directory, in which case Kodi should #include <foobar.h>, and then
the amcodec headers can do #include <barfoo.h>
The drawback with the second option is obviously the potential for
conflicting file names in /usr/include.
Since the patch doesn't work as-is, I've marked it as "Changes
Requested" in patchwork. Please come up with a better solution,
possibly by talking with the libamcodec maintainer.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list