[Buildroot] [PATCH 02/16 v3] core: commonalise the bundled and br2-external %_defconfig rules
Yann E. MORIN
yann.morin.1998 at free.fr
Sat Aug 27 14:16:50 UTC 2016
Thomas, All,
On 2016-08-27 16:12 +0200, Thomas Petazzoni spake thusly:
> On Sun, 17 Jul 2016 12:34:22 +0200, Yann E. MORIN wrote:
>
> > +define percent_defconfig
> > +%_defconfig: $(BUILD_DIR)/buildroot-config/conf $(1)/configs/%_defconfig outputmakefile
> > + # Override the BR2_DEFCONFIG from COMMON_CONFIG_ENV with the new defconfig
>
> This comment in here was a bit annoying, because it appears on stdout
> when you run "make <foo>_defconfig". So I've moved it outside of the
> target definition instead, in order to preserve the existing behavior
> in terms of what appears on stdout when loading a defconfig.
Well, that's how I did it first, but Arnout contended that the comment
should be moved like I did (or at least that's what I understood from
his review).
I'm happy you moved it. ;-)
Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list