[Buildroot] [PATCH 1/1] package/php: switch from libmysqlclient to mysqlnd

[Floris Bos]

Hi,

On 08/23/2016 09:52 PM, Thomas Petazzoni wrote:
> On Tue, 23 Aug 2016 18:54:48 +0200, Floris Bos wrote:
>> The Mysql Native Driver has been the default mysql driver since
>> PHP 5.4, but buildroot was still using libmysqlclient.
>>
>> Mysqlnd has several advantages such as improved memory management
>> and the more favorable PHP licensing terms.
>> (can combine it with proprietary PHP extensions like Ioncube
>> loader, while libmysqlclient requires commercial licensing if you
>> link to it and do not fall under their GPL/FOSS license exception)
>>
>> Signed-off-by: Floris Bos <bos at je-eigen-domein.nl>
> I see that you are changing the *existing* options to use the native
> driver rather than the libmysqlclient based one.
>
> Would there be any reason for someone to prefer the libmysqlclient
> based one over the native driver?
>
> I'm simply wondering if we should change the semantic of the existing
> options, or add new ones for the native driver. I very much prefer
> *less* options, so if the native driver is fine and a drop-in
> replacement for the libmysqlclient based one, I'm all for your patch,
> just wanted to confirm.

The upstream project changed the existing option as well.
Years ago, if you specified --with-pdo-mysql (without exact path) it 
defaulted to searching for libmysqlclient, even when mysqlnd was already 
an alternative.
Since the release of 5.4.0 (in 2012) it defaults to mysqlnd.

Not sure if anyone still has a reason to prefer libmysqlclient, mysqlnd 
is indeed a drop-in replacement.
I kinda have the expectation to get the same defaults when compiling in 
buildroot, as I would get if I compiled the upstream project manually.



Yours sincerely,

Floris Bos