[Buildroot] [PATCH] package/pppd: disable for musl toolchains

[Yegor Yefremov]

On Sat, Jul 16, 2016 at 8:33 PM, Romain Naour <romain.naour at gmail.com> wrote:
> Hi Thomas,
>
> Le 16/07/2016 à 20:24, Thomas Petazzoni a écrit :
>> Hello,
>>
>> On Sat, 16 Jul 2016 18:08:18 +0200, Romain Naour wrote:
>>> For the same reason as for ipsec-tools [1], disable pppd for musl
>>> toolchains.
>>> It also include <sys/cdefs.h> which is not provided by musl [2].
>>>
>>> This fixes a compilation error with musl libc because of undeclared
>>> __P and missing sys/cdefs.h include.
>>>
>>> Propagate the dependency to network-manager and rp-pppoe
>>> packages.
>>>
>>> [1] 33499484e457018203023cdfdd5286478f2ae381
>>> [2] http://wiki.musl-libc.org/wiki/FAQ#Q:_I.27m_trying_to_compile_something_against_musl_and_I_get_error_messages_about_sys.2Fcdefs.h
>>>
>>> Signed-off-by: Romain Naour <romain.naour at gmail.com>
>>> ---
>>>  package/network-manager/Config.in | 1 +
>>>  package/pppd/Config.in            | 5 +++--
>>>  package/rp-pppoe/Config.in        | 5 +++--
>>>  3 files changed, 7 insertions(+), 4 deletions(-)
>>
>> I've added a Config.in comment in the network-manager package, and
>> applied. Thanks!
>>
>> It's a bit sad that we have to disable packages just because of silly
>> __P macros, but there are indeed tons of them in pppd :-/
>
> Well, I'm also not really happy to disable packages in Buildroot for such reason :-/

Some MUSL related pull-requests appeared lately: from
https://github.com/paulusmack/ppp/pull/60 till
https://github.com/paulusmack/ppp/pull/65

I hope, they can be pulled in the near future.

Yegor