[Buildroot] [PATCH] i2c-tools: depend on BUSYBOX_SHOW_OTHERS

Peter Korsgaard peter at korsgaard.com
Mon Aug 1 21:39:19 UTC 2016


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Hello,
 > On Sun, 31 Jul 2016 15:56:09 +0200, Bartosz Golaszewski wrote:
 >> As of version 1.25.0 busybox by default includes a nearly complete
 >> implementation of i2c-tools. Hide the upstream version unless the
 >> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS option is selected.
 >> 
 >> Signed-off-by: Bartosz Golaszewski <bgolaszewski at baylibre.com>
 >> ---
 >> package/i2c-tools/Config.in | 1 +
 >> 1 file changed, 1 insertion(+)

 > Applied to master, thanks. However, I noticed that the Busybox symlinks
 > are installed in usr/sbin, while the full-blown i2c-tools binaries are
 > installed in usr/bin. Perhaps we should install the i2c-tools binaries
 > in usr/sbin, to follow what Busybox does, and have i2c-tools add
 > busybox to its DEPENDENCIES when busybox is enabled, so that it
 > overwrites the Busybox symlinks?

 > Peter?

Yes, I think that would be a good idea. E.G. Debian also install them
into usr/sbin:

https://packages.debian.org/stretch/amd64/i2c-tools/filelist

-- 
Venlig hilsen,
Peter Korsgaard 


More information about the buildroot mailing list