[Buildroot] [PATCH 2/8] package/glmark2: gl support also depends on X.org

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Apr 27 19:32:30 UTC 2016


Hello,

On Mon, 25 Apr 2016 14:20:16 +0200, Bernd Kuhls wrote:

> diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in
> index 9167fc5..10c88ee 100644
> --- a/package/glmark2/Config.in
> +++ b/package/glmark2/Config.in
> @@ -7,7 +7,7 @@ config BR2_PACKAGE_GLMARK2_EGL_GLES
>  config BR2_PACKAGE_GLMARK2_GL
>  	bool
>  	default y
> -	depends on BR2_PACKAGE_MESA3D_DRI_DRIVER
> +	depends on BR2_PACKAGE_MESA3D_OPENGL_GL

I know that may sound like a nitpicking debate, but I'm wondering if we
shouldn't keep BR2_PACKAGE_MESA3D_OPENGL_GL as an internal mesa3d
symbol, and instead use:

	depends on BR2_PACKAGE_HAS_LIBGL && BR2_PACKAGE_MESA3D

which really expresses what we want: we want an OpenGL implementation,
and this OpenGL implementation has to be mesa3d.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list