[Buildroot] [PATCH v2] linux: use $(LINUX_INSTALL_IMAGE_CMDS) instead of plain 'cp'

Sebastian Frias sf84 at laposte.net
Tue Apr 26 08:44:20 UTC 2016


Hi Thomas,

On 04/25/2016 09:43 PM, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 25 Apr 2016 16:52:17 +0200, Sebastian Frias wrote:
>> The target "$(LINUX_DIR)/.stamp_initramfs_rebuilt" uses its own
>> 'cp' command, instead of LINUX_INSTALL_IMAGE/LINUX_INSTALL_IMAGES_CMDS
>> provided by (or updated with) commit 055e6162bba7 ("linux: don't build
>> appended DTB image in place and support multiple images") and thus is
>> not operating properly when APPENDED_DTB is used.
>>
>> Indeed, it copies a single image, and does not copy the one with the DTB
>> appended.
>>
>> This patch replaces the 'cp' command with LINUX_INSTALL_IMAGE which
>> handles APPENDED_DTB.
>>
>> Fixes: 055e6162bba7 ("linux: don't build appended DTB image in place and
>> support multiple images")
>>
>> Signed-off-by: Sebastian Frias <sf84 at laposte.net>
>> ---
>> Changes v1 -> v2:
>>   - remove '-v' from cp (as suggested by thomas.petazzoni at free-electrons.com)
>>   - use LINUX_INSTALL_IMAGE instead of LINUX_INSTALL_IMAGES_CMDS (also suggested by thomas.petazzoni at free-electrons.com)
>> ---
>>  linux/linux.mk | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> The commit title was no longer matching what the commit was doing, so
> I've tweaked it, and applied your patch. Thanks!
> 

Oh, sorry about that (I had edited the patch manually), and thanks for fixing it! :-)

Best regards,

Sebastian



More information about the buildroot mailing list