[Buildroot] [PATCH 1/2] package/openjpeg: bump to version 2.1

Angelo Compagnucci angelo.compagnucci at gmail.com
Mon Apr 25 21:01:39 UTC 2016


Dear Samuel Martin,

2016-04-25 22:56 GMT+02:00 Samuel Martin <s.martin49 at gmail.com>:
> Angelo,
>
> On Mon, Apr 25, 2016 at 10:43 PM, Angelo Compagnucci
> <angelo.compagnucci at gmail.com> wrote:
>> Dear Samuel Martin
>>
> [...]
>>
>> I reviewed the logic a little bit more and I can confirm that keeping
>> the default is sensible:
>>
>> [1] if (BUILD_CODEC OR BUILD_MJ2)
>> [2] option(BUILD_THIRDPARTY "Build the thirdparty executables if it is
>> needed" OFF)
>> [3] ELSE (BUILD_THIRDPARTY)
>> [4] IF(ZLIB_FOUND)
>>     SET(Z_LIBNAME ${ZLIB_LIBRARIES} PARENT_SCOPE)
>>     SET(Z_INCLUDE_DIRNAME ${ZLIB_INCLUDE_DIRS} PARENT_SCOPE)
>>     message(STATUS "Your system seems to have a Z lib available, we
>> will use it to generate PNG lib")
>>     ELSE (ZLIB_FOUND) # not found
>>     message(STATUS "Z lib not found, activate BUILD_THIRDPARTY if you
>> want build it (necessary to build libPNG)")
>>
>> So at the end if BUILD_CODEC is ON (default) system libraries will
>> only be used if found.
>> Is not this the intended behaviuor?
> Certainly.
> However, they may exist or not, depending on the package selection and
> the build order, so my questions are:
> - are they required or optional stuff?

Rigth, they should be in OPENJPEG_DEPENDENCIES if found.

> - if optional, can we force using or not using them? (from build
> reproducibility perspective)

>From the make system perspective, nope. Actually they are built if
found, no way to explicitly enabling/disabling them.

>
>
> Regards,
>
> --
> Samuel



-- 
Profile: http://it.linkedin.com/in/compagnucciangelo


More information about the buildroot mailing list