[Buildroot] [PATCH 1/2] package/openjpeg: bump to version 2.1

[Samuel Martin]

On Mon, Apr 25, 2016 at 10:05 PM, Angelo Compagnucci
<angelo.compagnucci at gmail.com> wrote:
> Dear Thomas Petazzoni,
>
> 2016-04-25 21:28 GMT+02:00 Thomas Petazzoni
> <thomas.petazzoni at free-electrons.com>:
>> Hello,
>>
>> On Mon, 25 Apr 2016 17:20:22 +0200, Angelo Compagnucci wrote:
>>
>>> -ifeq ($(BR2_PACKAGE_LIBPNG),y)
>>> -OPENJPEG_DEPENDENCIES += libpng
>>> -OPENJPEG_CONF_OPTS += --enable-png
>>> -else
>>> -OPENJPEG_CONF_OPTS += --disable-png
>>> -endif
>>> -
>>> -ifeq ($(BR2_PACKAGE_TIFF),y)
>>> -OPENJPEG_DEPENDENCIES += tiff
>>> -OPENJPEG_CONF_OPTS += --enable-tiff
>>> -else
>>> -OPENJPEG_CONF_OPTS += --disable-tiff
>>> -endif
>>> -
>>> -ifeq ($(BR2_PACKAGE_LCMS2),y)
>>> -OPENJPEG_DEPENDENCIES += lcms2
>>> -OPENJPEG_CONF_OPTS += --enable-lcms2
>>> -else
>>> -OPENJPEG_CONF_OPTS += --disable-lcms2
>>> -endif
>>
>> What about those optional dependencies? They are no longer used?
>
> They are no longer present as cmake options, they are handled internally.
hmm, not that simple.
These thirdparty are still bundle with openjpeg, the parsing of the
thirdparty dir. is sensible to BUILD_CODEC [1] (which is ON by default
[2]) plus some magics [3,4] involving BUILD_THIRDPARTY.
So to prevent building the bundled 3rd parties, you should explicitly
add the dependencies and disable these flags.

[1] https://github.com/uclouvain/openjpeg/blob/master/CMakeLists.txt#L268
[2] https://github.com/uclouvain/openjpeg/blob/master/CMakeLists.txt#L254
[3] https://github.com/uclouvain/openjpeg/blob/master/CMakeLists.txt#L269


Regards,

-- 
Samuel