[Buildroot] [PATCH v1 1/4] libpjsip: add gnutls support and fix various things

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Apr 22 21:21:55 UTC 2016


Hello,

Thanks for your contributions!

On Fri, 22 Apr 2016 16:57:05 -0400, Patrick Keroulas wrote:
> Endianness for ARM.
> Add missing errno.
> Add multiple listeners.
> Fix ICE config and session.

As the commit title suggests, this patch does too many things in one
patch. Each of the things that you list here should be done by a
separate patch.

>  package/libpjsip/0003-Add-gnutls-support.patch     | 3373 ++++++++++++++++++++

Please don't include the generated configure script changes. Just patch
configure.ac, and mark the package with <pkg>_AUTORECONF = YES.

However, Buildroot has the policy of not carrying feature patches,
which this one clearly is. Some please get this patch integrated
upstream first, and then we can benefit from this feature in Buildroot.

Having large feature patches like this one in Buildroot would prevent
us from easily updating libpjsip in the future, which is not a
situation we like.

Patches fixing bugs/issues are OK, but not feature patches.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list