[Buildroot] [PATCH 1/1] Preliminary support for Raspberry Pi 3.

Peter Korsgaard peter at korsgaard.com
Fri Apr 22 20:38:29 UTC 2016


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Hello,
 > On Fri, 22 Apr 2016 22:18:51 +0200, Peter Korsgaard wrote:

 >> Thanks. Aren't these basically identical to the rpi1/rpi2 variants
 >> (except for the genimage script)? Please rework it to simply add a
 >> raspberrypi3 symlink like we do for raspberrypi2.

 > Why do we even have a symlink? If all files are the same, why aren't we
 > referencing board/raspberrypi/ files from the raspberrypi2_defconfig?

Because of some magic in post-image.sh that looks at the dirname to
figure out what genimage configuration to use:

BOARD_DIR="$(dirname $0)"
BOARD_NAME="$(basename ${BOARD_DIR})"
GENIMAGE_CFG="${BOARD_DIR}/genimage-${BOARD_NAME}.cfg"

According to git blame this comes from 8dd797a0549869 that you applied
;)

We could also solve it by passing an argument to the script using
BR2_ROOTFS_POST_SCRIPT_ARGS (or the generic genimage support stuff).

-- 
Venlig hilsen,
Peter Korsgaard 


More information about the buildroot mailing list