[Buildroot] [PATCH 2/4] linux-headers: indent custom choices

Vivien Didelot vivien.didelot at savoirfairelinux.com
Wed Apr 20 13:52:40 UTC 2016


Hi Thomas, Arnout,

Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

> Hello,
>
> On Wed, 20 Apr 2016 00:58:48 +0200, Arnout Vandecappelle wrote:
>
>>   We currently have 5 choice statements where the contents is indented, and 54 
>> where it's not. So I wouldn't say that we usually indent it...
>
> I agreed.
>
>>   That said, I'm not strictly against indenting choice contents: it's not going 
>> to be nested any deeper, and the lines are normally not that long. The only 
>> question is what to do with the help texts, because they would suddenly have to 
>> be wrapped at 82 characters...
>
> I prefer to keep things non-indented. Otherwise, to be consistent, we
> would also have to indent the config options within a if...endif block,
> or within a menuconfig...endmenu. And then suddenly you can have a
> choice nested in an if, nested in a menuconfig, and your indentation
> goes crazy.
>
> So, I'd say no.

I didn't take a look at other files, but only this one, and wanted to be
consistent with the rest of the code where the "Kernel Headers" config
entries are indented.

But I really don't mind, I'll drop this one ;-)

Thanks,
-v


More information about the buildroot mailing list