[Buildroot] [PATCH 2/3] c-icap: bump to version 0.4.2

[Thomas Petazzoni]

Hello,

On Wed, 20 Apr 2016 07:28:34 +0300, Baruch Siach wrote:

> configure.ac uses AC_TRY_RUN (inside AC_CACHE_CHECK) to test for 
> sem_init/sem_post and fcntl. The fourth AC_TRY_RUN parameter 
> (ACTION-IF-CROSS-COMPILING) of these tests gives this advice:
> 
>    [AC_MSG_ERROR([cross-compiling,
>         presetting ac_cv_10031b_ipc_sem=(yes|no) will help])]
>         )
>    ]
> 
>    [AC_MSG_ERROR([cross-compiling,
>         presetting ac_cv_fcntl=(yes|no) will help])]
>         )
>    ]

OK. I don't know why those tests are using AC_TRY_RUN(), but assuming
they really need to, then yes, pre-seeding the cache variables in the
only way.

> > Can you add a comment on top of this line that explains why those two
> > values need to be passed? Or at least, it should be explained in the
> > commit log (but a comment in the code is better IMO).
> 
> I'll add a comment.

Yes, just something like:

# Pre-seed cache variables for tests done with AC_TRY_RUN that are not
# cross-compile friendly

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com