[Buildroot] [PATCH v8 04/14] core: add HOST_SANITIZE_RPATH_HOOK to TARGET_FINALIZE_HOOKS

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Apr 19 07:21:17 UTC 2016


Hello,

On Tue, 19 Apr 2016 01:38:19 +0200, Arnout Vandecappelle wrote:

> > One tricky aspect though is that not all host packages are guaranteed
> > to be built by the time TARGET_FINALIZE_HOOKS is called. Indeed,
> > TARGET_FINALIZE_HOOKS is guaranteed to be called after all *target*
> > packages have been built. But if a host package is needed just to
> > build a filesystem image for example, it is not guaranteed that it will
> > be built before TARGET_FINALIZE_HOOKS is called.
> 
>   Actually, it is run after all explicitly selected packages have been built. So 
> this is yet another reason to also add Kconfig options for host packages.

Well, while I do like the fact that you try to find more arguments to
add Kconfig options for host packages, I am not sure this particular
one is a good reason. Indeed, as the name TARGET_FINALIZE_HOOKS
suggests, it finalizes the _target_, so there is no point in
guaranteeing that all host packages have been built *before* the hooks
in TARGET_FINALIZE_HOOKS are executed.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list