[Buildroot] [PATCH] support/scripts: fix graph-depends when run with python3

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Apr 18 09:35:06 UTC 2016


Hello,

On Sun, 17 Apr 2016 23:41:48 +0200, Samuel Martin wrote:
> Make graph-depends script opening the output file in text mode since
> only ascii characters will be written.
> 
> This change fixes the following error occuring when the default host
> python interpreter is python3:
> 
>   make: Entering directory '/opt/buildroot'
>   Getting targets
>   Getting dependencies for ['toolchain-external', 'toolchain', 'busybox', ...]
>   Getting dependencies for ['host-python3', 'host-pkgconf', 'host-gettext', ...]
>   Getting dependencies for ['host-libxml2', 'host-swig', 'host-m4', ...]
>   Getting version for ['toolchain-external', 'toolchain', 'busybox', ...]
>   Traceback (most recent call last):
>     File "/opt/buildroot/support/scripts/graph-depends", line 425, in <module>
>       outfile.write("digraph G {\n")
>   TypeError: a bytes-like object is required, not 'str'
>   Makefile:807: recipe for target 'graph-depends' failed
>   make[1]: *** [graph-depends] Error 1
>   Makefile:84: recipe for target '_all' failed
>   make: *** [_all] Error 2
>   make: Leaving directory '/opt/buildroot'
> 
> While with python2, adding 'b' to the openning mode has no effect on
> Linux (c.f. [2]), the above error is expected with python3 (c.f. [1]).
> 
> Therefore, just open the outfile in default (i.e. text) mode.
> 
> [1] https://docs.python.org/3/library/functions.html#open
> [2] https://docs.python.org/2/library/functions.html#open
> 
> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
> ---
>  support/scripts/graph-depends | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list