[Buildroot] [PATCH] package/racehound: fix comment

[Arnout Vandecappelle]

On 04/12/16 19:20, Yann E. MORIN wrote:
> racehound requires a kernel >= 3.14 to be built and to run.

  If I understand correctly, it actually doesn't need kernel headers >= 3.14, 
but only a kernel >= 3.14...

>
> However, the current conditions on the corresponding comments are wrong:
>    - the comment about the kernel has a dependency on the requested
>      headers
>    - the comment on the toolchain features does not have this condition.
>
> Thus, the comments are not shown/hidden under the appropriate
> conditions, like in this situation:
>    - toolchain with headers < 3.14 (e.g. Sourcery CodeBench x86/x86_64
>      2012.09 with headers 3.5)
>    - kernel 4.5 enabled

  So in this configuration, it should actually be possible to build racehound.

  If this is true, I would remove the dependency on kernel headers.

>
> this comment is shown:
>      racehound needs an Linux kernel >= 3.14 to be built

  But I would keep this comment if !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14, to make 
sure the user realizes that he needs a >= 3.14 kernel. He can still select the 
package if the headers ar < 3.14, so if he knows what he's doing it will be fine.

  Even better would be
	depends on !BR2_LINUX_KERNEL || \
		(BR2_PACKAGE_RACEHOUND && !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14)
i.e. only show the >= 3.14 warning in case you actually selected racehound.

>
> So, this is incorrect, because:
>   1- a kernel >= 3.14 is indeed to be built
>   2- the headers version mismatch is not reported
>
> Fix that by moving the dependency on the kernel headers to the
> appropriate comment and enhance it.
>
> Since there is no way we can know the kernel version to be built, we can
> not add such a condition; still, we leave the kernel message as-is.

  It can be tested in a pre-configure hook. But the cmake rules already check 
for that, so there's no need to do it again in buildroot.

>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> ---
>   package/racehound/Config.in | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/racehound/Config.in b/package/racehound/Config.in
> index 9f1011b..53e39a8 100644
> --- a/package/racehound/Config.in
> +++ b/package/racehound/Config.in
> @@ -27,10 +27,11 @@ config BR2_PACKAGE_RACEHOUND
>   	  https://github.com/winnukem/racehound
>
>   comment "racehound needs an Linux kernel >= 3.14 to be built"
> -	depends on !BR2_LINUX_KERNEL || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14
> +	depends on !BR2_LINUX_KERNEL
>   	depends on BR2_i386 || BR2_x86_64
>
> -comment "racehound needs a uClibc or (e)glibc toolchain w/ C++, wchar, dynamic library"
> +comment "racehound needs a uClibc or (e)glibc toolchain w/ C++, wchar, dynamic library, headers >= 3.14"
>   	depends on BR2_i386 || BR2_x86_64
>   	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || BR2_STATIC_LIBS \
> -		|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)
> +		|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC) \
> +		|| !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14

  Just to be clear: I think this comment shouldn't be changed at all.

  Assuming, of course, that my assumption is correct that it has no particular 
dependency on kernel headers.

  Regards,
  Arnout

>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF