[Buildroot] [PATCH] mosh: fix build with the Codescape IMG toolchain
Arnout Vandecappelle
arnout at mind.be
Tue Apr 5 21:47:45 UTC 2016
On 04/05/16 20:03, Baruch Siach wrote:
> The Codescape IMG toolchain does not provide the ssp library even though it's
> a glibc toolchain, and thus selects BR2_TOOLCHAIN_HAS_SSP. Add a patch that
> changes the compile test for -fstack-protector-all to a build test that
> correctly fails when ssp is missing.
>
> This makes the seeding of ssp related configure variables unnecessary.
So, this fixes the issue for mosh, but not for libpam-tacplus, powerpc-utils,
psmisc, ruby, sox, and stunnel...
Wouldn't it be better to fix BR2_TOOLCHAIN_HAS_SSP itself instead? Otherwise
there isn't much point in having this symbol... So it shouldn't be selected by
glibc/musl itself, but by the individual external toolchains. Cfr. the previous
discussion for sox [1].
That said, it would of course be a great idea to upstream the patch to mosh so
we can remove our workaround at some point.
Regards,
Arnout
[1] http://patchwork.ozlabs.org/patch/590047/
>
> Signed-off-by: Baruch Siach<baruch at tkos.co.il>
> ---
> ...ure.ac-link-test-for-fstack-protector-all.patch | 33 ++++++++++++++++++++++
> package/mosh/mosh.mk | 11 ++------
> 2 files changed, 35 insertions(+), 9 deletions(-)
> create mode 100644 package/mosh/0001-configure.ac-link-test-for-fstack-protector-all.patch
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
More information about the buildroot
mailing list