[Buildroot] [PATCH 1/2] libbluray: add optional fontconfig dependency

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Sep 29 17:41:54 UTC 2015


Baruch,

On Tue, 29 Sep 2015 15:58:22 +0300, Baruch Siach wrote:

> diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk
> index e10f7dbc8c73..f6a501a1083f 100644
> --- a/package/libbluray/libbluray.mk
> +++ b/package/libbluray/libbluray.mk
> @@ -24,6 +24,12 @@ else
>  LIBBLURAY_CONF_OPTS += --without-freetype
>  endif
>  
> +ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> +LIBBLURAY_DEPENDENCIES += fontconfig
> +else
> +LIBBLURAY_CONF_OPTS += --without-fontconfig
> +endif

I would prefer to have an explicit --with-fontconfig when
BR2_PACKAGE_FONTCONFIG=y. I know it's not the case for the other
dependencies already handled by libbluray.mk, so I've applied your
patch as is, and my comment can be fixed for all optional dependencies
of libbluray in a separate patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list