[Buildroot] [PATCH v3 4/4] package/rpm: add host variant

James Knight james.knight at rockwellcollins.com
Thu Sep 3 20:34:26 UTC 2015


Yann,

Thanks; and sorry for all these little mistakes.

On Thu, Sep 3, 2015 at 2:35 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> Same comment as for beecrypt: you do not need an intermediate variable,
> just re-use the target variable when defining the host variable; [...]
>
>     RPM_CONF_OPTS = \
>         --disable-largefile \
>         --disable-rpath \
>         [...]
>
>     HOST_RPM_CONF_OPTS = \
>         $(RPM_CONF_OPTS) \
>         --with-beecrypt \
>         --without-archive \
>         [...]

Question about this though, won't this be an issue for additional
configuration values set later in the file (ie. options added to
`RPM_CONF_OPTS`)?

When I clean up this patch and remove the intermediate variable, I
assume I should be declaring the host options such as:

    HOST_RPM_CONF_OPTS := \
        $(RPM_CONF_OPTS) \
        --with-beecrypt \
        --without-archive \
        [...]

Unless I've missed something?


More information about the buildroot mailing list