[Buildroot] [PATCH 2/4 v3] core/pkg-kernel-module: drop now-useles check for CONFIG_MODULES

Yann E. MORIN yann.morin.1998 at free.fr
Thu Sep 3 12:54:20 UTC 2015


This reverts commit 8df95d9 (pkg-kernel-module: die if kernel module
support is disabled).

Now that we force-enable support for modules in the kernel config, we
need not check it.

Besides, the check was broken, because it did not use $$ to dereference
LINUX_DIR, thus leading to systematic build failures when a package
using the kernel-module infra was enabled.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Cc: Peter Korsgaard <jacmet at uclibc.org>
Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Cc: Noé Rubinstein <noe.rubinstein at gmail.com>
Cc: Jan Viktorin <viktorin at rehivetech.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

---
Changes v2 -> v3:
  - add revert reference  (Arnout)

Changes v1 -> v2:
  - the check was broken anyway
---
 package/pkg-kernel-module.mk | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/package/pkg-kernel-module.mk b/package/pkg-kernel-module.mk
index f6730b8..200c91d 100644
--- a/package/pkg-kernel-module.mk
+++ b/package/pkg-kernel-module.mk
@@ -65,10 +65,6 @@ $(2)_MODULE_SUBDIRS ?= .
 # includes and other support files (Booo!)
 define $(2)_KERNEL_MODULES_BUILD
 	@$$(call MESSAGE,"Building kernel module(s)")
-	@if ! grep -Fqx 'CONFIG_MODULES=y' $(LINUX_DIR)/.config; then \
-		echo "ERROR: Kernel does not support loadable modules"; \
-		exit 1; \
-	fi
 	$$(foreach d,$$($(2)_MODULE_SUBDIRS), \
 		$$(LINUX_MAKE_ENV) $$($$(PKG)_MAKE) \
 			-C $$(LINUX_DIR) \
-- 
1.9.1



More information about the buildroot mailing list