[Buildroot] [PATCHv3 1/2] udisks: bump to version 1.0.5
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed Sep 2 14:13:38 UTC 2015
Dear Vicente Olivert Riera,
On Wed, 2 Sep 2015 15:12:33 +0100, Vicente Olivert Riera wrote:
> >> + # udisks needs libgudev which is provided by eudev. But, if you are
> >> + # using systemd, since they removed libgudev from it, you need to
> >> + # install the libgudev package to satisfy this dependency.
> >
> > I think the wording is not quite good yet. The sentence "udisks needs
> > libgudev which is provided by eudev" is wrong, because libgudev can
> > also be provided by libgudev. What about instead:
> >
> > # When eudev is used as the udev provider, libgudev is
> > # automatically provided as it is part of eudev. However, when
> > # systemd is used as the udev provider, libgudev is not
> > # provided, and needs to be built separately. This is why we
> > # select the libgudev package only if systemd is used.
> >
> > (Or something along those lines, my english is not perfect, for sure).
> >
> > Thomas
> >
>
> your explanation looks better to me. Care to use --amend before pushing
> the changes, please? :-P Or do you want me to send a v4 for this?
I may not be the one applying the changes: Peter is back online and
available to merge things, so he might be the one merging the patches.
So please send a v4.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list