[Buildroot] [PATCH] Revert "manual: Add notes about GitHub and hashes"

Maxime Hadjinlian maxime.hadjinlian at gmail.com
Sun Oct 18 15:32:23 UTC 2015


Hi Samuel, all

On Sun, Oct 18, 2015 at 5:26 PM, Samuel Martin <s.martin49 at gmail.com> wrote:

> This note is no longer needed, so remove it.
>
> Tarballs generated by GitHub are always the same, so hashes can be
> checked.
>
> This reverts commit 9474cc2594c8643301164500ce6eb62546da2b8f.
>
> Cc: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
> ---
>  docs/manual/adding-packages-directory.txt | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/docs/manual/adding-packages-directory.txt
> b/docs/manual/adding-packages-directory.txt
> index b66e447..8745c41 100644
> --- a/docs/manual/adding-packages-directory.txt
> +++ b/docs/manual/adding-packages-directory.txt
> @@ -449,13 +449,6 @@ strong hash yourself (preferably +sha256+, but not
> +md5+), and mention
>  this in a comment line above the hashes.
>
>  .Note
> -If +libfoo+ is from GitHub (see xref:github-download-url[] for details),
> we
> -can only accept a +.hash+ file if the package is a released (e.g. uploaded
> -by the maintainer) tarball. Otherwise, the automatically generated tarball
> -may change over time, and thus its hashes may be different each time it is
> -downloaded, causing a +.hash+ mismatch for that tarball.
> -
> -.Note
>  The number of spaces does not matter, so one can use spaces (or tabs) to
>  properly align the different fields.
>
> --
> 2.6.1
>
> I am all in favor for this, just a quick question:

Should we wait FOSDEM where we said that if there was not any problem we
would simply add all the missing hashes for GitHub packages ? Or we go back
on what we said and we do it now ?
And so, should we apply this now, or wait a bit ?

Samuel: There's a sentence two lines lower, that references the fact that
the 'none' type for the hashes is usefull for Github, it should go too
(haven't checked if there's more, but I don't think so)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151018/2156fb07/attachment.html>


More information about the buildroot mailing list