[Buildroot] [PATCH] busybox: enable fully featured hush shell for nommu
Peter Korsgaard
peter at korsgaard.com
Fri Oct 16 09:55:34 UTC 2015
>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
Hi,
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_HUSH_LOCAL,$(BUSYBOX_BUILD_CONFIG))
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_HUSH_RANDOM_SUPPORT,$(BUSYBOX_BUILD_CONFIG))
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_HUSH_EXPORT_N,$(BUSYBOX_BUILD_CONFIG))
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_HUSH_MODE_X,$(BUSYBOX_BUILD_CONFIG))
> I don't like this, since it makes it completely impossible to disable these
> hush features. I admit that it indeed doesn't make a significant difference, but
> on principle I'm against forcing this on the user.
Yeah, I also don't think this is really nice.
> But then we're running the fixups three times in the configure step, which
> feels a bit like overkill to me. So perhaps a more elegant solution would be the
> following: instead of calling sed-based fixups, use a kconfig fragment and
> merge_config to apply the fixups.
> Cc-ing our Kconfig infra expert to consider this.
Lets here what he has to say ;) A further complication is that busybox
uses a really old kconfig version.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list