[Buildroot] [PATCH v3 02/37] package/expedite: move to package directory

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Oct 10 12:55:56 UTC 2015


Dear Romain Naour,

On Sat, 10 Oct 2015 14:43:35 +0200, Romain Naour wrote:

> "We usually do not have a sub-directory for a family of related packages, so
> move expedite to package directory.

This is not exactly true. When they need to share the same version
number (example: qt5), then we do have a sub-directory for a family of
related packages. So I think this should be reworded a bit.

> > Also, it seems like you don't have rename detection enabled in Git.
> 
> Indeed, sorry for that... The patch generated with git format-patch didn't look
> like the one viewed through gitk.
> I fixed that using:
> git config --global diff.renames copies
> 
> Also the following patches moving efl packages to package directory have the
> same issue...

Perfect. It will indeed make the review easier.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list