[Buildroot] [PATCH 4/4] kodi: Without native RPC use libtirpc

Arnout Vandecappelle arnout at mind.be
Sat Oct 3 18:25:57 UTC 2015


On 03-10-15 17:45, Maxime Hadjinlian wrote:
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 But...

> ---
>  package/kodi/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/kodi/Config.in b/package/kodi/Config.in
> index 797f59d..e87bb32 100644
> --- a/package/kodi/Config.in
> +++ b/package/kodi/Config.in
> @@ -181,13 +181,14 @@ config BR2_PACKAGE_KODI_LIBMICROHTTPD
>  
>  config BR2_PACKAGE_KODI_LIBNFS
>  	bool "nfs"
> -	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
> +	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc

 I would have split this long line. And perhaps the comment should be
libnfs -> libtirpc


 Regards,
 Arnout


> +	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_PACKAGE_LIBNFS
>  	help
>  	  Enable NFS server support.
>  
> -comment "nfs support needs a toolchain w/ RPC support"
> -	depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
> +comment "nfs support needs a toolchain w/ threads support"
> +	depends on !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
>  
>  config BR2_PACKAGE_KODI_RTMPDUMP
>  	bool "rtmp"
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list