[Buildroot] [PATCH v3 2/4] pkg-generic: prevent _SITE URLs with a trailing slash

[Arnout Vandecappelle]

On 03-10-15 13:01, Arnout Vandecappelle wrote:
> On 30-09-15 11:45, Thomas Petazzoni wrote:
>> > Dear Luca Ceresoli,
>> > 
>> > On Mon, 28 Sep 2015 18:10:32 +0200, Luca Ceresoli wrote:
>> > 
>>> >>  # Retrieve the archive
>>> >>  $(BUILD_DIR)/%/.stamp_downloaded:
>>> >> +	@(echo "$($(PKG)_SITE)" | grep -Eq "[^/]$$" || \
>>> >> +		(echo "$(PKG)_SITE ($($(PKG)_SITE)) cannot have a trailing slash" && false))
>> > 
>> > You could use $(error ...) instead:
>> > 
>>> >> +	@(echo "$($(PKG)_SITE)" | grep -Eq "[^/]$$" || \
>>> >> +		$(error "$(PKG)_SITE ($($(PKG)_SITE)) cannot have a trailing slash"))
>  That's not going to work AFAIK. The whole thing would have to be converted to a
> make condition.

 E.g.:

ifeq ($(patsubst %/,ERROR,$($(PKG)_SITE)),ERROR)
$(error ...)
endif

 Or if that doesn't work:

ifeq ($(shell echo "$($(PKG)_SITE)" | grep -Eq "[^/]$$" || echo n),n)
$(error ...)
endif


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF