[Buildroot] [PATCH v14 1/1] squeezelite: new package

kei-k at ca2.so-net.ne.jp kei-k at ca2.so-net.ne.jp
Thu Oct 1 11:39:13 UTC 2015


Dear, Vincent, all.

I deeply appreciate if you suggest me which is preferred (or policy ?)
of buildroot community.

Regards,
Kawashima

kei-k at ca2.so-net.ne.jp writes:
> Dear, Vincent.
> 
> Thank you for your comment.
> 
> > ...fix the Makefile upstream (your github repo) instead of adding a
> > patch in Buildroot?
> 
> Since this modification is buildroot specific, modification should be
> embeded in buildroot environment (as patch file), I should untouch
> original source trees as possible as I can, that is my understanding.
> 
> But anyway, I will obey your (buildroot community) preference.
> 
> I will have 2 choice.
> 1) Use current method (patching to original Makefile).
> 2) Prepare modified Makefile.buildroot and add to my github repo.
> 
> Which is preferred ?
> Please advise me.
> 
> Regards,
> Kawashima
> 
> Vicente Olivert Riera writes:
> > Dear Hiroshi Kawashima,
> > 
> > On 09/30/2015 03:34 PM, kei-k at ca2.so-net.ne.jp wrote:
> > > Dear all.
> > > 
> > > I will appreciate if you point out anything I should improve for
> > > following patch.
> > > 
> > > Thanks,
> > > Kawashima
> > > 
> > >> Signed-off-by: Hiroshi Kawashima <kei-k at ca2.so-net.ne.jp>
> > >> ---
> > >> Changelog
> > >> v13 -> v14
> > >> - change to use patch file insted of using sed to generate Makefile.
> > 
> > [snip]
> > 
> > >> v12 -> v13
> > >> - change SQUEEZELITE_SITE to github (mine), cloned from original
> > >>   google code site (original site is unstable to fetch).
> > 
> > So you own a clone of that project on github, and the package you want
> > to add in Buildroot clones from it. Great! Then, why not...
> > 
> > [snip]
> > 
> > >> - to accomplish above, change to generate buildroot suitable Makefile fr
> om
> > >>   original squeezelite's Makefile (using 'override' directive for CFLAGS
> ,
> > >>   LDFLAGS).
> > 
> > ...fix the Makefile upstream (your github repo) instead of adding a
> > patch in Buildroot?
> > 
> > Regards,
> > 
> > Vincent.
> > 
> > [snip]
> ============================================================
>     Hiroshi Kawashima
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
============================================================
    Hiroshi Kawashima


More information about the buildroot mailing list