[Buildroot] [PATCH v5 1/2] package/unscd: new package

[Thomas Petazzoni]

Dear Doug Kehn,

On Mon, 23 Nov 2015 07:58:15 -0600, Doug Kehn wrote:

> diff --git a/package/unscd/Config.in b/package/unscd/Config.in
> new file mode 100644
> index 0000000..1639bca
> --- /dev/null
> +++ b/package/unscd/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_UNSCD
> +	bool "unscd"
> +	depends on BR2_TOOLCHAIN_USES_GLIBC
> +	depends on !BR2_GLIBC_NSCD

I think you should leave this BR2_GLIBC_NSCD thing on the side for now.
Just make unscd a normal package, and don't worry about nscd coming
from glibc: there is anyway no mechanism in Buildroot today to install
the nscd coming from the toolchain.

> +UNSCD_POST_EXTRACT_HOOKS += UNSCD_EXTRACT_DEBIAN
> +
> +define UNSCD_APPLY_DEBIAN_PATCHES
> +	$(APPLY_PATCHES) $(@D) $(@D)/debian/patches
> +endef
> +
> +UNSCD_POST_PATCH_HOOKS += UNSCD_APPLY_DEBIAN_PATCHES

This doesn't work because the patches don't end with an extension that
is recognized by our apply-patch script. So all what you see is:

>>> unscd 0.51 Patching
support/scripts/apply-patches.sh  /home/thomas/projets/buildroot/output/build/unscd-0.51 /home/thomas/projets/buildroot/output/build/unscd-0.51/debian/patches
Unsupported file type for /home/thomas/projets/buildroot/output/build/unscd-0.51/debian/patches/change_invalidate_request_info_output, skipping
Unsupported file type for /home/thomas/projets/buildroot/output/build/unscd-0.51/debian/patches/support_large_numbers_in_config, skipping

which makes the entire dance around applying the Debian patches useless.

Unfortunately, fixing this requires fixing our apply-patches script.
Generally speaking, I am not super happy with all the logic we need to
add in various packages to get them to apply the Debian patches. But
Debian packages vary quite a bit in the way the patches are organized,
so I don't know if it's doable to fix.

BTW any reason to not use the upstream version, at
http://busybox.net/~vda/unscd/nscd-0.52.c, which is higher than 0.51 ?

Can you look into this patching issue (or alternatively use 0.52 with
no patches) and send an updated version ?

Thanks !

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com