[Buildroot] [PATCH] qt5base: support OVERRIDE_SRCDIR

Peter Korsgaard peter at korsgaard.com
Wed Nov 25 06:21:28 UTC 2015


>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

 > On 24-11-15 23:40, Yann E. MORIN wrote:
 >> Peter, All,
 >> 
 >> On 2015-11-24 22:21 +0100, Peter Korsgaard spake thusly:
 >>> With OVERRIDE_SRCDIR we don't apply any of the qt5base patches, but the
 >>> custom specs files are needed to be able to build - So install these in the
 >>> configure step instead of having them as a patch.
 >> 
 >> IMHO, it make more sense to install them at post-patch (or post-extract)
 >> rather than at the beginning of the configure step.

 >  But that wouldn't solve the issue, that it is not applied for OVERRIDE_SRCDIR.
 > With OVERRIDE_SRCDIR, no extract or patch step is done, instead the rsync step
 > is done.

 >  We could add it in a POST_PATCH _and_ a POST_RSYNC hook, however.

But would it have any real advantage over just doing it in the configure
step? It would be more code, and this is arguable about configuring
qt5base, and we already do so for the QT5BASE_CONFIGURE_CONFIG_FILE
stuff.

-- 
Venlig hilsen,
Peter Korsgaard 


More information about the buildroot mailing list