[Buildroot] [PATCH 1/1] INSTALL for autotools packages with hardcoded '-s'

[Yann E. MORIN]

Jonathan, All,

On 2015-11-22 18:00 +0200, Jonathan Ben Avraham spake thusly:
> On Sun, 22 Nov 2015, Yann E. MORIN wrote:
> >Date: Sun, 22 Nov 2015 16:49:13 +0100
> >From: Yann E. MORIN <yann.morin.1998 at free.fr>
> >To: Jonathan Ben-Avraham <yba at tkos.co.il>
> >Cc: buildroot at busybox.net
> >Subject: Re: [Buildroot] [PATCH 1/1] INSTALL for autotools packages with
> >    hardcoded '-s'
> >
> >Jonathan, All,
> >
> >On 2015-11-22 17:31 +0200, Jonathan Ben-Avraham spake thusly:
> >>From: Jonathan Ben Avraham <yba at tkos.co.il>
> >>
> >>The Makefile.in's of some autotools packages such as yp-tools and ypbind-mt do
> >
> >Are you planning on submitting those two packages?
> 
> Yes, I have already tested them on an unsuspecting client.

Muhahaha! :-)

> >If so, you should probably have sent a patch series with this patch as
> >patch 1/3, followed by patches 2/3 and 3/3 to add the two packages.
> 
> Ok, that might solve the other problem I have been wrestling with

When you have multiple related changes to send, then you should send
them as what we call a "series". See git-send-email on how to do so. We
also have a blurb about that in our manual:
    http://buildroot.org/manual.html#submitting-patches

> , which is
> how to submit each package separately but add a top-level Config.in submenu
> called "NIS client" beneath "nfs-utils" that has both the yp-tools and
> ypbind-mt packages in the submenu.

Do not add a sub-directory for this. We only add a sub-directory when we
have a lot of packages of the same category (or when a single package
has a lot of options). "A lot" being pretty arbitrary, but "two" is not
"a lot".

[--SNIP--]
> >Could you not just set:
> >   YP_TOOLS_AUTORECONF = YES
> >   YPBIND_MT_AUTORECONF = YES
> >
> >to force re-generation of the autostuff?
> 
> That's exactly what I do, but the problem is that the Makefile.in's have the
> -s parameter hardcoded. This is an old and well-known issue that has a patch
> for each of these packages in Yocto.

Well, Makefile.in should be regenerated by autoreconf. Also, I've looked
at the git trees of both projects, and could not spot any hard-coded
'-s'.

(I tried to autoreconf them, too, but since my gettext is too old, it
fails).

> >(Note: it will need to depend on host-gettext, since it wants to run
> >autotopint)
> 
> I will study that again. I had thought that by configuring --without-nls I
> could avoid the gettext dependency. Maybe I didn't look carefully enough.

All I'm saying is that it is needed during autoreconf, hence the need
for _host-gettext_ (the gettext for the host, not for the target).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'