[Buildroot] [PATCH 4/6] package/libcurl: carefully override LD_LIBRARY_PATH

Peter Korsgaard peter at korsgaard.com
Tue Nov 17 09:09:26 UTC 2015


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > To build libcurl, we need to override LD_LIBRARY and force it to a sane
 > value, otherwise libcurl is confused when target == host (see a51ce319,
 > libcurl: fix configure with openssl when target == host).

 > That is currently OK, since we always set LD_LIBRARY_PATH to a non-empty
 > value.

 > However, we're soon to stop setting it at all.

 > So, if the user has an empty (or no) LD_LIBRARY_PATH in his envirnment,
 > we'd end up adding the current working directory to LD_LIBRARY_PATH (as
 > an empty entry in a colon-separated list is most probably interpreted as
 > meaning the currentworking directory, which we do know can cause issue,
 > and which we expfressely check against in support/dependencies/dependencies.sh

 > Fix that by only using an existing LD_LIBRARY_PATH if it is not empty.
 > Also use a Makefile construct as it is easier to read than a shell one
 > (we can do that, as all variables from the environment as available as
 > make variables).

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Cc: Peter Korsgaard <jacmet at uclibc.org>
 > Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list