[Buildroot] [PATCH 1/2] ruby: do not overwrite RUBY_CONF_ENV
Peter Korsgaard
peter at korsgaard.com
Tue Nov 10 10:28:21 UTC 2015
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:
> In commit 53bf889cdca77979814bc6b74170e2f104fc3b70 ("ruby: should not
> use dl_iterate_phdr() on Blackfin") we added
> ac_cv_func_dl_iterate_phdr=no to RUBY_CONF_ENV when building on the
> Blackfin architecture.
> However, while doing so, we overwrote the previous value of
> RUBY_CONF_ENV, which was defined to have custom CFLAGS:
> RUBY_CONF_ENV = CFLAGS="$(RUBY_CFLAGS)"
> This has no visible effect because the custom CFLAGS are only used on
> SuperH/SuperH 64, while the overwrite of RUBY_CONF_ENV takes place on
> Blackfin.
> However, it doesn't look very pretty, and future additions to
> RUBY_CONF_ENV may break this subtle behavior.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Committed, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list