[Buildroot] [PATCH] package/python-protobuf: eliminate unneeded build-time dependencies

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Nov 9 21:08:30 UTC 2015


Steven,

On Sun,  8 Nov 2015 09:08:09 -0800, Steven Noonan wrote:
> This was causing unexpected HTTP requests by the setup.py script for
> python-protobuf. These "dependencies" aren't actually required for a successful
> build, and are not staged into the target install directory.

The reference to the autobuild is missing. It should contain:

Fixes:

	http://autobuild.buildroot.org/results/e44/e44694f30e39266491a1040e284e504d6d37ef9e/

> 
> Signed-off-by: Steven Noonan <steven at uplinklabs.net>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Tested-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

(I have verified that your patch fixes the build problem in the minimal
chroot I use for Buildroot testing in my autobuilder instance)

> +++ b/package/python-protobuf/protobuf-2.6.1-disable-unneeded-build-dependencies.patch

This file name is not correct according to our patch naming policy. It
should be 0001-disable-unneeded-build-dependencies.patch.

Also, can you submit this change upstream ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list