[Buildroot] [PATCH v3 02/13] package/dhcp: systemd: rename environment file

Gabe Evans gabe at hashrabbit.co
Wed Nov 4 18:42:22 UTC 2015


Hi Thomas, all,

On Wed, Nov 4, 2015 at 2:18 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Maxime, Benoît, Gabe,
>
> On Wed, 4 Nov 2015 10:52:10 +0100, Maxime Hadjinlian wrote:
>
>> > diff --git a/package/dhcp/dhcpd.service b/package/dhcp/dhcpd.service
>> > index 7b265cb..5989506 100644
>> > --- a/package/dhcp/dhcpd.service
>> > +++ b/package/dhcp/dhcpd.service
>> > @@ -7,7 +7,7 @@ Type=forking
>> >  PIDFile=/run/dhcpd.pid
>> >  ExecStart=/usr/sbin/dhcpd -q -pf /run/dhcpd.pid $INTERFACES
>> >  KillSignal=SIGINT
>> > -EnvironmentFile=/etc/default/dhcpd.conf
>> > +EnvironmentFile=/etc/default/dhcpd
>> >
>> Maybe this should be:
>> EnvironmentFile-=/etc/default/dhcpd
>
> On the dropbear package, Gabe Evans said it may not be such a good idea
> to do this EnvironmentFile thing.
>
> Can we settle on a common decision ?
>
> (From my PoV, using this EnvironmentFile looked good as it would be a
> common mechanism between the systemd and Busybox/sysvinit cases to tune
> the configuration of services. But Gabe seemed to disagree.)
>
> Could systemd people in Buildroot decide what to do ? :-)
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

Maxime cleared everything up for me. I'm okay with this as long as the
environment file is optional with:
'EnvironmentFile=-/etc/default/dhcpd'. Under the rationale of sharing
configuration between Busybox/SysVinit it makes the most sense.

Thanks,
Gabe

-- 
Gabe Evans | Co-Founder & CTO
hashrabbit.co • angel.co/hashrabbit • github.com/gevans


More information about the buildroot mailing list