[Buildroot] [PATCH] protobuf: bump to 2.6.1

Steven Noonan steven at uplinklabs.net
Wed Nov 4 17:34:02 UTC 2015


On Wed, Nov 4, 2015 at 9:25 AM, DATACOM - henrique.marks
<henrique.marks at datacom.ind.br> wrote:
> Hello All
>
> I was involved in one of those threads, so let me clarify.
>
> There was an error in protobuf (upstream) that prevented it being built fot powerpc. In our project, we need protobuf 2.6.1 working with powerpc arch.
>
> We have a local build of protobuf 2.6.1 that works with powerpc arch. We just didn't have time to submit it upstream (yet). So, i am going to attach our changes here, so that you can use it together with your work.

What puzzles me is that protobuf 2.6.1 doesn't have any
PowerPC-related macros in src/google/protobuf/stubs/platform_macros.h,
and it doesn't look like your patch adds any.

> Tha Patch (0001) corrects the wrong protobuf behaviour, and it is already applied upstream (but not in this version).
>
> The rest is the Config.in and protobuf.mk
>
> What else must be done:
>
> Some other packages, that depends on protobuf, have a dependency on !BR2_powerpc, so they are not built for powerpc just because of protobuf. Now that protobuf builds on powerpc, this restriction can be lifted up. This is what we don't have yet to submit upstream.
>
> Thats it, thanks and sorry for the long email.
>
> ----- Mensagem original -----
>> De: "Steven Noonan" <steven at uplinklabs.net>
>> Para: "Thomas Petazzoni" <thomas.petazzoni at free-electrons.com>
>> Cc: buildroot at buildroot.org
>> Enviadas: Quarta-feira, 4 de novembro de 2015 14:58:16
>> Assunto: Re: [Buildroot] [PATCH] protobuf: bump to 2.6.1
>
>> On Wed, Nov 4, 2015 at 7:28 AM, Steven Noonan <steven at uplinklabs.net> wrote:
>>> On Wed, Nov 4, 2015 at 3:03 AM, Thomas Petazzoni
>>> <thomas.petazzoni at free-electrons.com> wrote:
>>>> Dear Steven Noonan,
>>>>
>>>> On Wed,  4 Nov 2015 00:37:21 -0800, Steven Noonan wrote:
>>>>> Signed-off-by: Steven Noonan <steven at uplinklabs.net>
>>>>> ---
>>>>>  package/protobuf/protobuf.hash | 2 ++
>>>>>  package/protobuf/protobuf.mk   | 2 +-
>>>>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>>>>  create mode 100644 package/protobuf/protobuf.hash
>>>>
>>>> There have already been several attempts at bumping protobuf to 2.6.x,
>>>> but each time there were some issues.
>>>>
>>>> Search for:
>>>>
>>>> Subject: [Buildroot] [PATCH 1/1] protobuf: bump version to 2.6.1
>>>> Date: Mon, 22 Jun 2015 14:58:59 -0300
>>>>
>>>> Subject: [Buildroot] [PATCH 1/1] protobuf/protobuf-c: bump versions
>>>> Date: Thu, 13 Aug 2015 21:41:21 -0400
>>>>
>>>> Can you look into these threads and check that your bump takes into
>>>> account those problems ?
>>>
>>> Thanks for pointing those out. I'll take a look.
>>
>> One of the threads I found is confusing. It bumped protobuf to 2.6.1
>> but also enabled building for PowerPC. But I see no indication in the
>> protobuf 2.6.1 sources that PowerPC is a supported architecture, so I
>> wouldn't have expected it to work -- and the patch was presumably not
>> applied for that reason. This issue should not affect my patch, as I
>> didn't touch the architecture requirements in
>> package/protobuf/Config.in (or in anything depending on protobuf).
>>
>> I also saw threads talking about compile problems on pre-GCC 4.7
>> toolchains, but I successfully built on x86_64 with as old as GCC 4.4
>> (but didn't try older than that).
>>
>>>> Most notably, make sure that protobuf-c builds fine, and
>>>> python-protobuf builds fine. But look at the threads for other
>>>> potential issues.
>>
>> I'll submit a separate patch upgrading protobuf-c to v1.1.1.
>>
>> With the protobuf 2.6.1 patch and my [unsubmitted] protobuf-c v1.1.1
>> patch, I successfully built with this defconfig (basically
>> qemu_x86_64_defconfig + protobuf and any packages using it):
>>
>> BR2_x86_64=y
>> BR2_KERNEL_HEADERS_VERSION=y
>> BR2_DEFAULT_KERNEL_VERSION="4.2"
>> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_2=y
>> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>> BR2_TOOLCHAIN_BUILDROOT_CXX=y
>> BR2_TARGET_GENERIC_GETTY_PORT="tty1"
>> BR2_LINUX_KERNEL=y
>> BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.2"
>> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
>> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/x86_64/linux-4.2.config"
>> BR2_PACKAGE_OLA=y
>> BR2_PACKAGE_PYTHON=y
>> BR2_PACKAGE_PYTHON_PROTOBUF=y
>> BR2_PACKAGE_PROTOBUF_C=y
>> BR2_PACKAGE_COLLECTD=y
>> BR2_PACKAGE_MOSH=y
>> BR2_TARGET_ROOTFS_EXT2=y
>> # BR2_TARGET_ROOTFS_TAR is not set
>>
>>
>> And to cover all my bases I also tried the same with a similarly
>> modified qemu_mipsel_malta_defconfig:
>>
>> BR2_mipsel=y
>> BR2_mips_32r2=y
>> BR2_KERNEL_HEADERS_VERSION=y
>> BR2_DEFAULT_KERNEL_VERSION="4.2"
>> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_2=y
>> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>> BR2_TOOLCHAIN_BUILDROOT_CXX=y
>> BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
>> BR2_LINUX_KERNEL=y
>> BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.2"
>> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
>> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/mipsel-malta/linux-4.2.config"
>> BR2_LINUX_KERNEL_VMLINUX=y
>> BR2_PACKAGE_OLA=y
>> BR2_PACKAGE_PYTHON=y
>> BR2_PACKAGE_PYTHON_PROTOBUF=y
>> BR2_PACKAGE_PROTOBUF_C=y
>> BR2_PACKAGE_COLLECTD=y
>> BR2_PACKAGE_MOSH=y
>> BR2_TARGET_ROOTFS_EXT2=y
>> # BR2_TARGET_ROOTFS_TAR is not set
>>
>>
>> Didn't run into any build problems with either one.
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> Dr. Henrique Marks
> henrique.marks at datacom.ind.br
> R. América, 1000 - Eldorado do Sul - RS
> CEP: 92990-000 - Brasil
> Fone: +55 51 3933 3000 - Ramal 3466


More information about the buildroot mailing list