[Buildroot] [PATCH v3 02/13] package/dhcp: systemd: rename environment file

[Maxime Hadjinlian]

Hi Thomas, all

On Wed, Nov 4, 2015 at 11:18 AM, Thomas Petazzoni <
thomas.petazzoni at free-electrons.com> wrote:

> Maxime, Benoît, Gabe,
>
> On Wed, 4 Nov 2015 10:52:10 +0100, Maxime Hadjinlian wrote:
>
> > > diff --git a/package/dhcp/dhcpd.service b/package/dhcp/dhcpd.service
> > > index 7b265cb..5989506 100644
> > > --- a/package/dhcp/dhcpd.service
> > > +++ b/package/dhcp/dhcpd.service
> > > @@ -7,7 +7,7 @@ Type=forking
> > >  PIDFile=/run/dhcpd.pid
> > >  ExecStart=/usr/sbin/dhcpd -q -pf /run/dhcpd.pid $INTERFACES
> > >  KillSignal=SIGINT
> > > -EnvironmentFile=/etc/default/dhcpd.conf
> > > +EnvironmentFile=/etc/default/dhcpd
> > >
> > Maybe this should be:
> > EnvironmentFile-=/etc/default/dhcpd
>
> On the dropbear package, Gabe Evans said it may not be such a good idea
> to do this EnvironmentFile thing.
>
> Can we settle on a common decision ?
>
> (From my PoV, using this EnvironmentFile looked good as it would be a
> common mechanism between the systemd and Busybox/sysvinit cases to tune
> the configuration of services. But Gabe seemed to disagree.)
>
I still have to read that thread, I'll get to it in a few minutes.
The mechanism in itself is good, adding the '-' simply makes the file
optional. For me, a program must be able to start without options, or they
are not options but mandatory parameters (which is a bit contradictory)

>
> Could systemd people in Buildroot decide what to do ? :-)
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151104/e0fc767a/attachment.html>