[Buildroot] [PATCH 2/2] powerpc-utils: remove --without-librtas

[Baruch Siach]

Hi Sam,

On Mon, May 11, 2015 at 03:53:03PM +1000, Sam Bobroff wrote:
> On Mon, May 11, 2015 at 07:34:45AM +0300, Baruch Siach wrote:
> > On Mon, May 11, 2015 at 10:43:27AM +1000, Sam Bobroff wrote:
> > > On 08/05/15 14:57, Baruch Siach wrote:
> > > > Why not make librtas an optional dependency?
> > > 
> > > I thought about making it optional, but there seemed to be two reasons
> > > to always include it:
> > > 
> > > * librtas is a small library and it provides a lot of functionality to
> > > powerpc-utils. Why leave it out?
> > > 
> > > * Distros (AFAIK) always include librtas when providing powerpc-utils,
> > > so it would surprise users to provide a powerpc-utils without it by
> > > default. So if I did make it optional, I think it should be using some
> > > method that caused librtas to be included by default or at least
> > > provided some indication in the menu that they may want to go and enable
> > > librtas. Then I thought this was a bit complicated for a use case that I
> > > couldn't find a reason for.
> > 
> > These are valid reasons. What is the target installed size of librtas compared 
> > to powerpc-utils?
> 
> This might be a bit rough but it looks like:
> 
> * librtas: 360Kb
> * powerpc-utils with librtas: 1,660Kb
> .. for a total of  2020Kb
> 
> * powerpc-utils without librtas: 484Kb
> 
> So it looks like the increase is about 1.5Mb (or 3x, depending on how you look
> at it).

This is a significant increase. In this case I think it is best to give the 
user an explicit option like you suggested. Mentioning these numbers in the 
option help text should also be useful, I guess.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -