[Buildroot] [PATCH v3 1/4] autobuild-run: encapsulate subprocess calls

[Thomas Petazzoni]

Dear André Erdmann,

On Sun, 26 Apr 2015 23:47:50 +0200, André Erdmann wrote:
> Preparation step for passing LANG to worker (sub-)processes,
> allows to redirect stdin/stdout/stderr, which all default to devnull now
> unless specified otherwise.
> This makes the "yes"-pipe in "make oldconfig" redundant.
> 
> Signed-off-by: André Erdmann <dywi at mailerd.de>

I'm fine with the idea, but I have a doubt about the implementation.

> +    def popen(self, cmdv, **kwargs):

> +    def run_cmd(self, cmdv, **kwargs):

> +    def run_cmd_write_to(self, outstream, cmdv, **kwargs):

> +    def run_cmd_get_stdout(self, cmdv, **kwargs):

Why are these methods part of the SysInfo class? What is the relation
between running commands, and verifying which tools are available on
the host machine?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com