[Buildroot] [autobuild v2 2/3] autobuild-run: also save CMake config log files on package failure
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Mon May 4 20:12:37 UTC 2015
Dear André Erdmann,
On Thu, 30 Apr 2015 00:54:54 +0200, André Erdmann wrote:
> config_files = set(('config.log', ...))
>
> It's negligible in terms of real time difference (<= 0.0d seconds),
> but for efficiency reasons, don't use a tuple or list when doing
> lookups ("fname in config_files").
>
> os.walk() might return 100s or 1000s of file names in total,
> and for each fname, you have to through the entire list/tuple
> (until fname found or end of list, whatever comes first).
> Data structures like set/frozenset/dict perform lookups faster (on average).
Can you submit a follow-up patch implementing this suggestion?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list