[Buildroot] [PATCH 05/35] pkg-generic: allow full URLs for <pkg>_EXTRA_DOWNLOADS

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Mar 30 07:26:21 UTC 2015


Dear Yann E. MORIN,

On Sun, 29 Mar 2015 23:08:31 +0200, Yann E. MORIN wrote:

> And here I was going to suggest you could squash the two together,
> because they're basically doing exactly the same thing, but on
> different sets. So I wondered why you did not catch this, even
> though you state it explicitly in the commit log.
> 
> It would have been just possible to extend the existing loop over
> _PATCH like so:
> 
>     $(foreach p,$($(PKG)_PATCH) $($(PKG)_EXTRA_DOWNLOADS),\
> 
> And then, I noticed patch 33, which eventually gets rid of it anyway.
> So, OK.
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Yes, exactly, a later patch refactors completely this part of the code.

I must admit that the organization of the patches may not be optimal,
but it's not easy to find a good split of things, while keeping patches
small and minimal.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list