[Buildroot] [PATCH v9] package/sysdig: New package

[Arnout Vandecappelle]

On 26/03/15 21:37, Angelo Compagnucci wrote:
> Dear Ryan Barnett,
> 
> 2015-03-26 19:38 GMT+01:00 Ryan Barnett <ryan.barnett at rockwellcollins.com>:
>> > Hi Angelo,
>> >
>> > On Thu, Mar 26, 2015 at 2:48 AM, Angelo Compagnucci
>> > <angelo.compagnucci at gmail.com> wrote:
>>> >> Sysdig is open source, system-level exploration:
>>> >> capture system state and activity from a running Linux
>>> >> instance, then save, filter and analyze.
>>> >>
>>> >> Signed-off-by: Angelo Compagnucci <angelo.compagnucci at gmail.com>
>> >
>> > It would be good to carry forward previous reviews when you submit a
>> > new version of a patch. In your v8 of this patch Yegor Yefremov
>> > reviewed your patch so after your Signed-off-by line you should put
>> > this:
>> >
>> > Reviewed-by: Yegor Yefremov <yegorslists at googlemail.com>
> Are you sure? IMO, If the patch changes it should be reviewed again.

 It basically depends on how much you still changed after that reviewed-by was
given. In this case, it indeed probably changed too much to keep the tag.

 For Yegor's convenience, however, it could be good to add something like:

Previous-version-reviewed-by: ...

(At least in my case, I tend to look more carefully at the patches I reviewed
before, and I tend to forget which ones I reviewed in the past.)


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F